[PATCH] Various svnbook fixes

Øyvind A. Holm sunny at sunbase.org
Wed Aug 17 18:09:41 CDT 2005

On 2005-08-17 23:46:36 Max Bowsher wrote:
> Øyvind A. Holm wrote:
> > On 2005-08-17 08:36:52 C. Michael Pilato wrote:
> > >   If not commented on below, I agree with Max's opinions on the 
> > >   patch.
> > > [...]
> >
> > Thank you for the thorough review of the patch, cmpilato and maxb. 
> > And mthelen for digging it up, good catch. :)
> >
> > Now that I know what the general view is on the different changes, I 
> > can clean up the patch, possibly splitting it up to keep related 
> > changes together. There are also some new additions to it which I 
> > also can include. The new patch (with log messages) arrives in a 
> > little while.
> Attached is the cleaned patch, containing the results of the reviews, 
> plus re-wrapping of lines made overly long by the changes.
> I didn't commit it yet because I haven't yet got around to writing a 
> log message. If you'd like to write the log and then commit it, please 
> do.

Ah, thanks for cleaning it up. I was sitting here splitting and 
tweaking, but now I can get these changes out of the way first. I can 
take care of the log message and perform the commit. There are some more 
changes along the same scheme which I’ve found, some quite identical 
(periods outside parentheses and such). Shall I create a new patch for 
those, or is it OK to include them in the same commit?

-- sunny256

More information about the svnbook-dev mailing list