[PATCH] post-commit post-revprop-change post-lock post-unlock hooks documentation

Mark E. Hamilton mhamilt at sandia.gov
Thu Apr 3 15:54:50 CDT 2008

The description for the four post hooks (post-commit, 
post-revprop-change, post-lock, and post-unlock) all say this:

The output from, and exit value returned by the post-commit hook program 
are ignored.

However, this is not exactly correct, since if the exit value is set to 
non-zero the stderr output will be marshalled back to the user 
(similarly to the pre-* version of the hook.) If this is the desired 
behavior (and I like it, since it helps diagnose hook-script failures,) 
IMO the documentation should say something like this:

If the post-commit hook program returns a non-zero exit status the 
commit *will not* be aborted, since it has already completed. However, 
anything printed to stderr will be marshalled back to the client, 
allowing for diagnosis of hook failures.

I've attached a patch that makes this change (with the appropriate 
textual differences for each hook.)

Mark E. Hamilton
Orion International Technologies, Inc.
Sandia National Laboratory, NM.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ch09-reference.xml.diff
URL: <http://www.red-bean.com/pipermail/svnbook-dev/attachments/20080403/988a03db/attachment.ksh>

More information about the svnbook-dev mailing list